Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvoitko
To complete the pull request process, please assign patrickxys after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickxys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Hi @mvoitko. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@googlebot I signed it!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvoitko
To complete the pull request process, please assign patrickxys after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickxys in a comment when ready.

The full list of commands accepted by this bot can be found here.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@yanniszark could you please approve?

Could anyone review please?

It seems that you are in the wrong repository. You need to fix this in kubeflow/kubeflow

@Arhell could you please approve?

/test all

@Arhell could you please approve?

https://github.com/kubeflow/manifests/blob/master/OWNERS#L1

@PatrickXYS could you please approve?

@mvoitko

You are in the wrong repository. If you ignore my help again it is your problem. Your changes belong here https://github.com/kubeflow/kubeflow/tree/master/components/crud-web-apps/jupyter/manifests/base Buf if you would have checked that you would have seen that it is already fixed and will me synchronized to kubeflow/manifests for 1.6

So just close this non-issue. If you want to get approved you should rather have 10-20 merged PRs.
if you want to help here are some big PRs to review
kubeflow/pipelines#7819
kubeflow/pipelines#7938
kubeflow/pipelines#7725

and important issues
kubeflow/pipelines#4790

You can also attend the kubeflow and KFP community meetings

@juliusvonkohout Thank you for the details! It would be also nice if this "If you want to get approved you should rather have 10-20 merged PRs." was explicitly mentioned in the internal acl.

Getting to the point of the issue. I still don't understand why there is code duplication. In Kubeflow 1.5 the manifests are applied from this repo. Why couldn't we update them here?

@juliusvonkohout Thank you for the details! I still don't understand why there is code duplication. In Kubeflow 1.5 the manifests are applied from this repo. Why couldn't we update them here?

That is just the development structure. Each subgroup develops independently and prepares for the next release. Then their manifests get pulled into this meta repository.

That is just the development structure. Each subgroup develops independently and prepares for the next release. Then their manifests get pulled into this meta repository.
Oh. Cool. Thanks for the explanation. It wasn't obvious. Why are git submodules not used for this purpose instead of copy-paste?
So can I update the jupyter web app manifests for kubeflow 1.5?

No, just close this and wait for #2200 (comment)
You can also find me on the kubeflow slack channel https://kubeflow.slack.com/ssb/redirect